Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker(install): fallback to journalctl to print docker daemon logs #201

Merged
merged 4 commits into from Nov 16, 2023

Conversation

crazy-max
Copy link
Member

related to crazy-max/ghaction-setup-docker#45

colima only supports Ubuntu image since 0.6.0 which runs docker as systemd unit: https://github.com/abiosoft/colima/blob/main/docs/FAQ.md#version-v060-and-newer

Version v0.6.0 and newer

Colima uses Ubuntu as the underlying image. Other distros are not supported.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
colima only supports Ubuntu image since 0.6.0 which
runs docker as systemd unit.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

Provisioning on Ubuntu does not seem to work anymore to install a custom docker release as colima overrides packages installation on startup now 😕: https://github.com/docker/actions-toolkit/actions/runs/6889709856/job/18741269217#step:5:531

  time="2023-11-16T11:01:55Z" level=trace msg="cmd [\"lima\" \"sh\" \"-c\" \"grep \\\"^UBUNTU_CODENAME\\\" /etc/os-release | cut -d= -f2\"]"
  time="2023-11-16T11:01:56Z" level=trace msg="cmd [\"lima\" \"sh\" \"-c\" \"sudo apt-get install --reinstall --print-uris -qq \\\"docker.io\\\" | cut -d\\\"'\\\" -f2\"]"

...


Selecting previously unselected package docker.io.
Preparing to unpack .../docker.io_24.0.5-0ubuntu1_amd64.deb ...
Unpacking docker.io (24.0.5-0ubuntu1) ...

Looks hardcoded: https://github.com/abiosoft/colima/blob/565ddd0c15a3068d0f11cb301691e3540f9b5596/environment/vm/lima/dependencies.go#L18

Maybe we could set a custom lima profile I'm not sure.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review November 16, 2023 11:41
@crazy-max crazy-max merged commit 97573bf into docker:main Nov 16, 2023
21 checks passed
@crazy-max crazy-max deleted the colima-update branch November 16, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant