Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildx: build for local platform #135

Merged
merged 1 commit into from Jul 12, 2023

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jul 12, 2023

When building buildx on macOS runner when Docker engine is installed it will build against linux/amd64 instead of darwin/amd64. We should always match the local platform.

cc @maxcleme

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Member

@maxcleme maxcleme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@crazy-max crazy-max merged commit f1593e3 into docker:main Jul 12, 2023
15 checks passed
@crazy-max crazy-max deleted the fix-buildx-install-platform branch July 12, 2023 12:23
Mogyuchi pushed a commit to 4m-mazi/gh-test that referenced this pull request Jul 13, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[docker/setup-buildx-action](https://togithub.com/docker/setup-buildx-action)
| action | minor | `v2.8.0` -> `v2.9.1` |

---

### Release Notes

<details>
<summary>docker/setup-buildx-action
(docker/setup-buildx-action)</summary>

###
[`v2.9.1`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.9.1)

[Compare
Source](https://togithub.com/docker/setup-buildx-action/compare/v2.9.0...v2.9.1)

- Bump
[@&#8203;docker/actions-toolkit](https://togithub.com/docker/actions-toolkit)
from 0.7.0 to 0.7.1 in
[docker/setup-buildx-action#248
- Fixes an issue where building Buildx does not match the local platform
([docker/actions-toolkit#135)

**Full Changelog**:
docker/setup-buildx-action@v2.9.0...v2.9.1

###
[`v2.9.0`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.9.0)

[Compare
Source](https://togithub.com/docker/setup-buildx-action/compare/v2.8.0...v2.9.0)

- Bump
[@&#8203;docker/actions-toolkit](https://togithub.com/docker/actions-toolkit)
from 0.6.0 to 0.7.0 in
[docker/setup-buildx-action#246
- Adds support to cache Buildx binary to hosted tool cache and GHA cache
backend

**Full Changelog**:
docker/setup-buildx-action@v2.8.0...v2.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Mogyuchi/gh-test).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNTkuNyIsInVwZGF0ZWRJblZlciI6IjM2LjUuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants