Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: comment opt for getInputList #115

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

crazy-max
Copy link
Member

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from jedevc June 9, 2023 12:13
@crazy-max

This comment was marked as outdated.

@crazy-max
Copy link
Member Author

crazy-max commented Jun 12, 2023

Looks like we need this change for the build push action: docker/build-push-action#879. The bake action already has support for comments but making it enabled by default in the toolkit introduced a breaking change.

PTAL @jedevc

Copy link

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@crazy-max crazy-max merged commit 495c96b into docker:main Jun 13, 2023
30 checks passed
@crazy-max crazy-max deleted the input-comment-opt branch June 13, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants