Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #29942 -- Avoided Python 3.9+ syntax in docs build. #18167

Merged
merged 1 commit into from
May 21, 2024

Conversation

smithdc1
Copy link
Member

@smithdc1 smithdc1 commented May 15, 2024

Djangoproject.com uses Python 3.8 and therefore the docs build process needs to be compatible with this version.

Dict union operator was added in Python 3.9.

Trac ticket number

Ticket-29942

Branch description

Provide a concise overview of the issue or rationale behind the proposed changes.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

Djangoproject.com uses Python 3.8 and therefore the docs build process needs to be compatible with this version.

Dict union operator was added in Python 3.9.
@smithdc1
Copy link
Member Author

Hi @nessita just to check. Do you have this one on your list before the feature freeze? I'd consider this a release blocker.

I'm happy to help manage this through trac. Should I create a new ticket for it?

@nessita
Copy link
Contributor

nessita commented May 21, 2024

Hi @nessita just to check. Do you have this one on your list before the feature freeze? I'd consider this a release blocker.

I'm happy to help manage this through trac. Should I create a new ticket for it?

I'm about to review right now, thanks!

@nessita
Copy link
Contributor

nessita commented May 21, 2024

Tested in Python 3.8, docs are built without errors now. Thank you @smithdc1!

@nessita nessita merged commit 15fff62 into django:main May 21, 2024
28 checks passed
@smithdc1 smithdc1 deleted the docs_build branch May 21, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants