Add redis to test matrix #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
approved these changes
Jan 10, 2024
This was referenced Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #376 this PR aims to add redis to test matrix.
It also adds channels versions to test matrix in order to ensure compatibility with it.
Redis compatibility is tested only against current stable release of channels while channels compatibility is tested only against current stable release of redis.
During the tests I had to increase minimun redis supported version to 4.6 due to https://github.com/redis/redis-py/issues/2754 which was introduced in the 4.5 branch and fixed in 4.6.
File "channels_redis/channels_redis/pubsub.py", line 297, in _do_receiving message = await self._pubsub.get_message( File "channels_redis/.tox/py310-chmain-redis45/lib/python3.10/site-packages/redis/asyncio/client.py", line 927, in get_message response = await self.parse_response(block=(timeout is None), timeout=timeout) File "channels_redis/.tox/py310-chmain-redis45/lib/python3.10/site-packages/redis/asyncio/client.py", line 804, in parse_response response = await self._execute( File "channels_redis/.tox/py310-chmain-redis45/lib/python3.10/site-packages/redis/asyncio/client.py", line 784, in _execute return await conn.retry.call_with_retry( File "channels_redis/.tox/py310-chmain-redis45/lib/python3.10/site-packages/redis/asyncio/retry.py", line 59, in call_with_retry return await do() File "channels_redis/.tox/py310-chmain-redis45/lib/python3.10/site-packages/redis/asyncio/client.py", line 785, in lambda: command(*args, **kwargs), TypeError: SentinelManagedConnection.read_response() got an unexpected keyword argument 'disconnect_on_error'This should solve #348 and #366.