Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add python 3.12 and drop 3.7 #374

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

marksweb
Copy link
Contributor

This adds python 3.12 to the tests and drops 3.7

Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at that. Lovely 🎁

@carltongibson carltongibson merged commit 7823759 into django:main Nov 23, 2023
6 checks passed
@marksweb marksweb deleted the test/py312 branch November 23, 2023 19:26
@smithdc1
Copy link
Member

Should this be increased too?

https://github.com/django/channels_redis/blob/main/setup.py#L32

@marksweb
Copy link
Contributor Author

Should this be increased too?

https://github.com/django/channels_redis/blob/main/setup.py#L32

Good spot David. I can update, though there are reasons why that might not want to be updated (yet).

@carltongibson
Copy link
Member

Yes, good spot. (Likely there's a reference or two elsewhere, README say?, that a search would catch.)

@marksweb
Copy link
Contributor Author

I'll take a look before I get going with the same for channels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants