Enable a few of the disabled biome rules #2091
Merged
+112
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way how they do not override the value of 'this' makes implementing handlers and callbacks so nuch nicer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the initial migration to biome I disabled a few rules to keep the code
changes minimal. I reenable some of the less controversial rules here.
The remaining rules are discouraging
forEachin favor offor ... of(not donefor now because of the amount of change it introduces) and the discouragement
of assignments in expressions. I want to have a closer look there because the
code reads strange (but it probably isn't).
Checklist:
docs/changes.rst.