Async compatible redirect panel #1976
Merged
+39
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salty-ivy
changed the title
aprocess_request method as common pattern in base panel class.
debug_toolbar/panels/redirects.py
Outdated
Comment on lines
41
to
43
| response = super().process_request(request) | ||
| if iscoroutine(response): | ||
| return self.aprocess_request(request) |
There was a problem hiding this comment.
This flow will call super().process_request twice. We probably want to avoid that. I have some ideas, but none that I know are great. What do you think?
There was a problem hiding this comment.
since aprocess_request is exclusive to RedirectsPanel
- we can pass response from
process_requestinaprocess_requestas an argument. - or else we change the check from coroutine to checking request being an instance
ASGIRequest.
There was a problem hiding this comment.
I think 2. won't work either : )
tim-schilling
approved these changes
Aug 6, 2024
|
Looks good! Thanks for working with me to arrive at this solution. |
tim-schilling
force-pushed
the
async-panel-patterns
branch
from
2fa6da5 to
60b742c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
async compatible
RedirectsPanel.Checklist:
docs/changes.rst.