Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7588 overwrite widget attrs #7589

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Fix #7588 overwrite widget attrs #7589

merged 3 commits into from
Jun 21, 2023

Conversation

jrief
Copy link
Contributor

@jrief jrief commented Jun 20, 2023

Description

see #7588 for details

@jrief
Replace PositiveSmallIntegerField against PositiveIntegerField
4bc5da9
@jrief
fix #7588
8a4bc4d 
Do not overwrite attrs passed in from existing slug widget
@jrief
Copy link
Contributor Author

jrief commented Jun 20, 2023

sorry, this pr integrates pr #7585, which was left over.

shall I rebase?

@fsbraun fsbraun added the 4.1 label Jun 20, 2023
fsbraun
fsbraun approved these changes Jun 20, 2023
View reviewed changes
Copy link
Sponsor Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrief We need to port this change back to develop, too. Can you create another PR for develop?

@fsbraun fsbraun merged commit db6cfe0 into develop-4 Jun 21, 2023
175 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsbraun fsbraun fsbraun approved these changes

Assignees
No one assigned
Labels
4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrief @fsbraun