Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add (back) navigation extenders to advanced settings #7578

Merged
merged 5 commits into from
Jun 17, 2023

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Jun 6, 2023

Description

It seems that when restructuring the advanced settings form, navigation_extenders haven been dropped from the fields:

fields = [
'login_required',
'reverse_id',
'application_urls',
'application_namespace',
'application_configs',
]

The functionality seems untouched. I have not found any reasoning in the release notes or commits removing the navigation_extenders. Since the commit was a rather large refactor, I can imagine that dropping the navigation extenders was not on purpose.

This PR adds back the navigation_extenders field.

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic -> n/a
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from Aiky30 June 6, 2023 09:13
@fsbraun fsbraun added the 4.1 label Jun 6, 2023
@fsbraun fsbraun requested a review from a team June 6, 2023 09:38
@fsbraun fsbraun merged commit 3e3a86b into django-cms:develop-4 Jun 17, 2023
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants