Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unlocalize ids to avoid js errors for ids greater than 999 #7577

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Jun 5, 2023

Description

On sites that have more than 1000 pages, when rendering admin/cms/page/tree/menu.html all the page ids and node ids are rendered localized, with e.g. commas or apostrophes for thousands separators.

When we then expand a node, those node's data-id are picked up and stored in local storage under cms_cookie in their localized form.

This has been fixed in 3.11 but remains open for the develop-4 branch.

Related resources

Checklist

  • I have opened this pull request against develop
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from a team June 5, 2023 18:43
Co-authored-by: Marco Bonetti <marco@cruncher.ch>
@fsbraun fsbraun merged commit 52e6f87 into django-cms:develop-4 Jun 6, 2023
88 checks passed
@fsbraun fsbraun deleted the fix/localized-ids branch June 6, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants