Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide legacy features in v4 admin/toolbar #7521

Merged
merged 5 commits into from
Apr 25, 2023

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Apr 10, 2023

Description

Some legacy features are still available in django CMS v4 to allow for migration. This PR hides their admin entries unless the setting CMS_HIDE_LEGACY_FEATURES is set to True.

So far it hides the static placeholder admin. Static placeholders are replaced by static aliases of the djangocms-alias package.

This PR is draft in case other features have to be hidden, too. Please do comment if you find a legacy v3 feature visible in django CMS 4.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun added the 4.1 label Apr 10, 2023
@fsbraun fsbraun marked this pull request as ready for review April 25, 2023 13:50
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fsbraun fsbraun merged commit 59fa62c into django-cms:develop-4 Apr 25, 2023
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants