Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page content's get_absolute_url needs to return URL of page content's language #7519

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Apr 5, 2023

Description

The page content's get_absolute_url should return the URL of the page content object, i.e. in the page content's language.

This is relevant, for example, for the "View published" button in versioning.

Underlying issue

With the current language being, say, English, clicking "View published" for a page content object in a different language will lead to the English published URL.

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun marked this pull request as ready for review April 5, 2023 14:16
@fsbraun fsbraun added the 4.1 label Apr 5, 2023
@fsbraun fsbraun requested a review from marksweb April 5, 2023 14:17
@fsbraun fsbraun changed the title fix: page content's get_aboslute_url returns url of page content's language fix: page content's get_aboslute_url needs to return URL of page content's language Apr 5, 2023
@fsbraun fsbraun changed the title fix: page content's get_aboslute_url needs to return URL of page content's language fix: page content's get_aboslute_url needs to return URL of page content's language Apr 5, 2023
@fsbraun fsbraun changed the title fix: page content's get_aboslute_url needs to return URL of page content's language fix: page content's get_absolute_url needs to return URL of page content's language Apr 5, 2023
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fsbraun fsbraun merged commit 06a08a7 into django-cms:develop-4 Apr 6, 2023
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants