-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add setting to redirect slugs to lowercase et al. #7510
Merged
fsbraun
merged 18 commits into
django-cms:develop-4
from
fsbraun:feat/redirect_to_lowercase_slug
Mar 8, 2023
Merged
feat: add setting to redirect slugs to lowercase et al. #7510
fsbraun
merged 18 commits into
django-cms:develop-4
from
fsbraun:feat/redirect_to_lowercase_slug
Mar 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the REDIRECT_TO_LOWERCASE_SLUG option which will cause the cms to redirect requests with an non-lowercase slug if no page with that slug is found. Implements django-cms#1324
fsbraun
changed the title
Feat/redirect to lowercase slug
feat: add setting to redirect slugs to lowercase
Mar 8, 2023
fsbraun
changed the title
feat: add setting to redirect slugs to lowercase
feat: add setting to redirect slugs to lowercase et al.
Mar 8, 2023
marksweb
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry picks the changes of #7489 and #7509 for django CMS v4
Related resources
Checklist
develop