Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Show language menu in toolbar only if at least two languages are configured #7508

Merged
merged 14 commits into from
Mar 4, 2023
Merged

fix: Show language menu in toolbar only if at least two languages are configured #7508

merged 14 commits into from
Mar 4, 2023

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Mar 3, 2023

Description

This PR only makes the language menu appear in the toolbar if at least two languages are configured.

This allows to set USE_I18N to True for Django and translate all English strings to whatever language you prefer without triggering the language menu to appear.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun added the 4.1 label Mar 3, 2023
@fsbraun fsbraun requested a review from marksweb March 3, 2023 18:18
@fsbraun fsbraun merged commit f805d5a into django-cms:develop-4 Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fsbraun @marksweb