Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Icon update #7494

Merged
merged 16 commits into from
Feb 3, 2023
Merged

feat: Icon update #7494

merged 16 commits into from
Feb 3, 2023

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Feb 1, 2023

Description

This PR updates the icon library for a more consistent user experience. It provides icon styles in a new css file cms.icons.css which can be used by other packages to allow for a uniform icon set.

Icon naming now consistently follows the rule cms-icon-<function>.

Historically, some icons were named after their content (e.g., cms-icon-cogs). Those icons remain available for the moment but are deprecated. Use the new icons instead: cms-icon-advanced-settings.

The pencil icon was used for settings and edit. Now it is deprecated and there are new icons for edit, edit-new, and settings.

Also, icons of some core packages are included:

  • djangocms-versioning
  • djangocms-alias
  • djangocms-moderation
  • djangocms-version-locking.

Here's a preview of the new "look and feel":
image

image

New icons:

  • advanced-settings: image
  • alias: image
  • apphook: image
  • archive: image
  • comment: image
  • cut: image
  • edit: image
  • edit-new: image
  • manage-versions: image
  • moderate: image (thanks to @svandeneertwegh !)
  • publish: image
  • redo: image
  • rename: image
  • settings: image
  • undo: image
  • unlock: image
  • unpublish: image
  • view: image

Included but deprecated

These icons describe content not functionality and are deprecated.

  • cogs
  • eye
  • layers
  • pencil
  • scissors
  • puzzle

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun added the 4.1 label Feb 1, 2023
@fsbraun fsbraun merged commit 7150398 into django-cms:develop-4 Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants