-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Icon update #7494
Merged
Merged
feat: Icon update #7494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsbraun
force-pushed
the
feat/iconupdate
branch
from
February 1, 2023 11:38
9c1e651
to
52d72f0
Compare
marksweb
approved these changes
Feb 1, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the icon library for a more consistent user experience. It provides icon styles in a new css file
cms.icons.css
which can be used by other packages to allow for a uniform icon set.Icon naming now consistently follows the rule
cms-icon-<function>
.Historically, some icons were named after their content (e.g.,
cms-icon-cogs
). Those icons remain available for the moment but are deprecated. Use the new icons instead:cms-icon-advanced-settings
.The pencil icon was used for settings and edit. Now it is deprecated and there are new icons for edit, edit-new, and settings.
Also, icons of some core packages are included:
Here's a preview of the new "look and feel":
New icons:
Included but deprecated
These icons describe content not functionality and are deprecated.
Checklist
develop-4