-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstrings for autodoc #7436
Conversation
… toolbar to the backend
…quest_pass or the toolbar will be wrongly configured
…ne query parameter is given. Needs to work with many
Reverse formatting change Co-authored-by: Aiky30 <Aiky30@users.noreply.github.com>
Correct formatting Co-authored-by: Aiky30 <Aiky30@users.noreply.github.com>
Comment above not at end of line Co-authored-by: Aiky30 <Aiky30@users.noreply.github.com>
Update method doc
Remove trailing space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @fsbraun
It doesn't need it, but it could also test that the old create_title
raises the deprecation warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @fsbraun
The only thing I thought of was that there could be a test for ensuring create_title
raises the warning.
Description
Related resources
This PR adds documentation docstring for sphinx' autodoc feature to pull from the source code.
cms/models/pluginmodel.py/
it turns out that a defunctcopy_plugin
function was left over from versions 3.xCMSPlugin.copy_plugin
function.create_title
tocreate_page_content
incms/api.py
. For ensure compatibility, acreate_title
function is retained. It issues a deprecation warning and callscreate_page_content
. This will require a change in the monkey patch routine of djangocms-versioning.Checklist
develop