Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow for Django 4.1 in setup.py #7424

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Oct 28, 2022

Description

PR #7418 introduced support for Django 4.1 but setup.py did not allow for Django 4.1. This mini-PR fixes this.

"packaging" is named as a dependency which replaces the diskutil's deprecated LooseVersion

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from marksweb October 28, 2022 19:38
@fsbraun fsbraun added the 4.1 label Oct 28, 2022
@fsbraun
Copy link
Sponsor Member Author

fsbraun commented Oct 28, 2022

Thanks very much @marksweb ! Such a glitch is always embarrassing...

@fsbraun fsbraun merged commit d5f12c9 into develop-4 Oct 28, 2022
@fsbraun fsbraun deleted the fix/setupDependencies branch December 30, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants