feat: graceful plugin exceptions #7423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… toolbar to the backend
…quest_pass or the toolbar will be wrongly configured
…ne query parameter is given. Needs to work with many
Reverse formatting change Co-authored-by: Aiky30 <Aiky30@users.noreply.github.com>
Correct formatting Co-authored-by: Aiky30 <Aiky30@users.noreply.github.com>
Comment above not at end of line Co-authored-by: Aiky30 <Aiky30@users.noreply.github.com>
Update method doc
Remove trailing space
…he plugin template
Add: Buggy test plugin
marksweb
approved these changes
Oct 28, 2022
vinitkumar
reviewed
Oct 30, 2022
There was a problem hiding this comment.
@fsbraun Made a remark about alternative representation of string. Please let me know if you agree or disagree?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Plugins raising an exception making the page uneditable. As a bit of sugar this PR catches exceptions that are raised
rendermethodrender_templateExceptions are logged (on error level) and developers can use Django's
LOGGINGsetting to configure on how to process the logs.Local development servers will typically show the traceback on the console.
Should an exception occur a placeholder with a short notice is rendered in edit mode. Double clicking on it will open the edit modal for the plugin. This way potential misconfigurations can be changed.
Related resources
Checklist
develop-4