-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize populating title cache for Page model. #7177
Optimize populating title cache for Page model. #7177
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@zkne Thanks very much for this PR! Can you have a look at the failing tests? Indeed, it would be great to have the improved population of the page content cache. |
@fsbraun thanks for reminding me of this PR. I will update it in the following days. |
@fsbraun Can you please check the PR now, I've updated the tests.
|
@zkne This looks really good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested this w/ versioning which monkey patches both PageContent.objects
as well as Page.page_content_set
. I do not see a side effect there.
Description
Optimizes the way the title cache is populated.
Related resources
Checklist
develop