Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] #7588

Closed
1 of 2 tasks
jrief opened this issue Jun 20, 2023 · 1 comment
Closed
1 of 2 tasks

[BUG] #7588

jrief opened this issue Jun 20, 2023 · 1 comment

Comments

@jrief
Copy link
Contributor

jrief commented Jun 20, 2023

Description

cms.admin.ContentForm overwrites attributes of slug widget.

Steps to reproduce

When setting the attributes of a slug widgets, these attributes are overwritten in

django-cms/cms/admin/forms.py

Line 222 in 3e3a86b

self.fields['slug'].widget = SlugWidget(attrs={"language": self._language})

This is unexpected behavior.

Additional information (CMS/Python/Django versions)

Branch develop-4. Latest commit hash: 52e6f87
All Django/Python versions.

Do you want to help fix this issue?

I have a patch. PR upcoming.

  • Yes, I want to help fix this issue and I will join #workgroup-pr-review on Slack to confirm with the community that a PR is welcome.
  • No, I only want to report the issue.
jrief added a commit that referenced this issue Jun 20, 2023
@jrief
fix #7588
8a4bc4d 
Do not overwrite attrs passed in from existing slug widget
@jrief jrief mentioned this issue Jun 20, 2023
Merged
fsbraun added a commit that referenced this issue Jun 21, 2023
@jrief @fsbraun
Fix #7588 overwrite widget attrs (#7589)
db6cfe0 
* Replace PositiveSmallIntegerField against PositiveIntegerField

* fix #7588

Do not overwrite attrs passed in from existing slug widget

---------

Co-authored-by: Fabian Braun <fsbraun@gmx.de>
@fsbraun
Copy link
Sponsor Member

fsbraun commented Jul 6, 2023

@jrief Can we close this?

@fsbraun fsbraun closed this as completed Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrief @fsbraun