Fix Tellor EVMCall implementation in DIVAOwnershipSecondary and update OZ libs #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that openzeppelin's ECDSA library removed the signature v check in version 4.8 which required a minor adjustment in the relevant tests. Read more about it here: OpenZeppelin/openzeppelin-contracts#3591
Walodja1987
changed the title
Walodja1987
requested review from
Sascha5,
GuardianAudits and
ComposableSecurityTeam
GuardianAudits
approved these changes
Apr 24, 2023
This was
linked to
issues
Apr 25, 2023
Sascha5
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2: Fix wrong implementation of EVMCall in DIVAOwnershipSecondary
While running the tests, I noticed that openzeppelin's ECDSA library had a small change in the error message for incorrect signature
vvalues starting from version 4.8, which required a minor adjustment in the relevant tests. Read more about it here: OpenZeppelin/openzeppelin-contracts#3591As this adjustment is related to the recommendation to update openzeppelin NPM dependencies in
package.json, I addressed #4 in this PR as well.