[release/2.8] bump up golang version (alternative)

[thaJeztah]

• alternative to [release/2.8] bump up golang version #3812 (rebased that branch, and split cherry-picks)
• supersedes / closes [release/2.8] bump up golang version #3812

Backports of:

• bump up golang v1.17 #3518
• Dockerfile: switch to xx #3641
• Update to xx 1.1.1 #3693
• (partial backport) ci: cleanup ci workflow #3644
  • commit: b066451
  • commit: 0e17e54

Diff with #3812

diff --git a/.dockerignore b/.dockerignore
new file mode 100644
index 00000000..e660fd93
--- /dev/null
+++ b/.dockerignore
@@ -0,0 +1 @@
+bin/
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 22d16e74..7da7e640 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -87,7 +87,6 @@ jobs:
           draft: true
           files: |
             bin/*.tar.gz
-            bin/*.zip
             bin/*.sha256
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/Dockerfile b/Dockerfile
index 913e2c37..bfa4a694 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -13,7 +13,7 @@ ENV CGO_ENABLED=0
 WORKDIR /go/src/github.com/docker/distribution
 
 FROM base AS version
-ARG PKG="github.com/distribution/distribution"
+ARG PKG="github.com/docker/distribution"
 RUN --mount=target=. \
   VERSION=$(git describe --match 'v[0-9]*' --dirty='.m' --always --tags) REVISION=$(git rev-parse HEAD)$(if ! git diff --no-ext-diff --quiet --exit-code; then echo .m; fi); \
   echo "-X ${PKG}/version.Version=${VERSION#v} -X ${PKG}/version.Revision=${REVISION} -X ${PKG}/version.Package=${PKG}" | tee /tmp/.ldflags; \
diff --git a/docker-bake.hcl b/docker-bake.hcl
index 4dd5a100..91686e60 100644
--- a/docker-bake.hcl
+++ b/docker-bake.hcl
@@ -1,15 +1,3 @@
-// GITHUB_REF is the actual ref that triggers the workflow
-// https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables
-variable "GITHUB_REF" {
-  default = ""
-}
-
-target "_common" {
-  args = {
-    GIT_REF = GITHUB_REF
-  }
-}
-
 group "default" {
   targets = ["image-local"]
 }
@@ -20,13 +8,11 @@ target "docker-metadata-action" {
 }
 
 target "binary" {
-  inherits = ["_common"]
   target = "binary"
   output = ["./bin"]
 }
 
 target "artifact" {
-  inherits = ["_common"]
   target = "artifact"
   output = ["./bin"]
 }
@@ -43,8 +29,13 @@ target "artifact-all" {
   ]
 }
 
+// Special target: https://github.com/docker/metadata-action#bake-definition
+target "docker-metadata-action" {
+  tags = ["registry:local"]
+}
+
 target "image" {
-  inherits = ["_common", "docker-metadata-action"]
+  inherits = ["docker-metadata-action"]
 }
 
 target "image-local" {
diff --git a/registry/handlers/basicauth_prego14.go b/registry/handlers/basicauth_prego14.go
index 6cf10a25..01290adf 100644
--- a/registry/handlers/basicauth_prego14.go
+++ b/registry/handlers/basicauth_prego14.go
@@ -1,3 +1,4 @@
+//go:build !go1.4
 // +build !go1.4
 
 package handlers
diff --git a/registry/storage/blobwriter_nonresumable.go b/registry/storage/blobwriter_nonresumable.go
index 32f13097..38267cf6 100644
--- a/registry/storage/blobwriter_nonresumable.go
+++ b/registry/storage/blobwriter_nonresumable.go
@@ -1,3 +1,4 @@
+//go:build noresumabledigest
 // +build noresumabledigest
 
 package storage
diff --git a/registry/storage/driver/gcs/gcs.go b/registry/storage/driver/gcs/gcs.go
index 86dc87f1..66d0d1ad 100644
--- a/registry/storage/driver/gcs/gcs.go
+++ b/registry/storage/driver/gcs/gcs.go
@@ -10,6 +10,7 @@
 // Note that the contents of incomplete uploads are not accessible even though
 // Stat returns their length
 //
+//go:build include_gcs
 // +build include_gcs
 
 package gcs
diff --git a/registry/storage/driver/gcs/gcs_test.go b/registry/storage/driver/gcs/gcs_test.go
index e58216be..4ae9aa3f 100644
--- a/registry/storage/driver/gcs/gcs_test.go
+++ b/registry/storage/driver/gcs/gcs_test.go
@@ -1,3 +1,4 @@
+//go:build include_gcs
 // +build include_gcs
 
 package gcs
diff --git a/registry/storage/driver/oss/oss.go b/registry/storage/driver/oss/oss.go
index 1dcf42b8..8738b1e0 100644
--- a/registry/storage/driver/oss/oss.go
+++ b/registry/storage/driver/oss/oss.go
@@ -7,6 +7,7 @@
 // Because OSS is a key, value store the Stat call does not support last modification
 // time for directories (directories are an abstraction for key, value stores)
 //
+//go:build include_oss
 // +build include_oss
 
 package oss
diff --git a/registry/storage/driver/oss/oss_test.go b/registry/storage/driver/oss/oss_test.go
index 438d9a48..e042bb75 100644
--- a/registry/storage/driver/oss/oss_test.go
+++ b/registry/storage/driver/oss/oss_test.go
@@ -1,3 +1,4 @@
+//go:build include_oss
 // +build include_oss
 
 package oss

[thaJeztah]

@crazy-max PTAL if the diff looks correct 😅

[crazy-max]

not for this pr but we should bump some actions as Node 12 is deprecated: https://github.com/distribution/distribution/actions/runs/4924320699

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, docker/metadata-action@v3, docker/setup-buildx-action@v1, docker/bake-action@v1, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

[crazy-max]

we should update to 1.2.1 in follow-up

[thaJeztah]

Thanks @crazy-max !

I'll do a follow-up to go1.19.9 as well (as go1.18 is EOL)