[release/2.8] Add code to handle pagination of parts. Fixes max layer size of 10GB bug #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
davidspek
commented
May 3, 2023
davidspek
commented
- backport of Add code to handle pagination of parts. Fixes max layer size of 10GB bug #2815
Closed
|
@davidspek can you please make the CI pass? |
|
@davidspek this should fix the CI: https://github.com/distribution/distribution/pull/3843/files |
|
Thanks for the reviews. I'm traveling at the moment but I'll try and fix this PR later today or tomorrow. |
Add code to handle pagination of parts. Fixes max layer size of 10GB bug Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
|
@flavianmissi Should be good for reviewing now |
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## release/2.8 #3893 +/- ##
============================================
Coverage 58.72% 58.72%
============================================
Files 102 102
Lines 7104 7104
============================================
Hits 4172 4172
Misses 2286 2286
Partials 646 646 ☔ View full report in Codecov by Sentry. |
thaJeztah
reviewed
May 9, 2023
| @@ -31,7 +31,7 @@ jobs: | |||
| run: | | |||
| sudo apt-get -q update | |||
| sudo -E apt-get -yq --no-install-suggests --no-install-recommends install python2-minimal | |||
| cd /tmp && go get -u github.com/vbatts/git-validation | |||
| cd /tmp && go install github.com/vbatts/git-validation@latest | |||
There was a problem hiding this comment.
FWIW; this one was already included in 2392893, so should dissolve when rebasing.
milosgajdos
approved these changes
May 9, 2023
|
PTAL @thaJeztah @corhere @squizzi |
corhere
approved these changes
May 9, 2023
5 tasks
5 tasks
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Jul 29, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [registry](https://github.com/distribution/distribution) | patch | `2.8.1` -> `2.8.2` | --- ### Release Notes <details> <summary>distribution/distribution (registry)</summary> ### [`v2.8.2`](https://github.com/distribution/distribution/releases/tag/v2.8.2) [Compare Source](distribution/distribution@v2.8.1...v2.8.2) ##### What's Changed - Revert registry/client: set `Accept: identity` header when getting layers by [@​ndeloof](https://github.com/ndeloof) in distribution/distribution#3783 - Parse `http` forbidden as denied by [@​vvoland](https://github.com/vvoland) in distribution/distribution#3914 - Fix [CVE-2022-28391](https://www.cve.org/CVERecord?id=CVE-2022-28391) by bumping alpine from 3.14 to 3.16 by [@​thaJeztah](https://github.com/thaJeztah) ([#​3650](distribution/distribution#3650)) - Fix [CVE-2023-2253](https://www.cve.org/CVERecord?id=CVE-2023-2253) runaway allocation on /v2/\_catalog by [@​josegomezr](https://github.com/josegomezr) [`521ea3d9`](distribution/distribution@521ea3d) - Fix panic in inmemory driver by [@​wy65701436](https://github.com/wy65701436) in distribution/distribution#3815 - bump up golang version (alternative) by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#3903 - Dockerfile: update xx to v1.2.1 by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#3907 - update to go1.19.9 by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#3908 - Add code to handle pagination of parts. Fixes max layer size of 10GB bug by [@​DavidSpek](https://github.com/DavidSpek) in distribution/distribution#3893 - Dockerfile: fix filenames of artifacts by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#3911 **Full Changelog**: distribution/distribution@v2.8.1...v2.8.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yMy4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/20 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.