Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/2.8] Fix panic in inmemory driver #3815

Merged

Conversation

wy65701436
Copy link
Collaborator

@wy65701436 wy65701436 commented Dec 4, 2022

Signed-off-by: Shengjing Zhu <zhsj@debian.org>
@thaJeztah thaJeztah changed the title Fix panic in inmemory driver [release/2.8] Fix panic in inmemory driver Dec 4, 2022
@thaJeztah thaJeztah closed this Apr 17, 2023
@thaJeztah thaJeztah reopened this Apr 17, 2023
@thaJeztah
Copy link
Member

Hm, right so looks like this fails because it's installing "github.com/vbatts/git-validation" "latest", which installs a version of golang.org/x/sys that's incompatible with go1.16

cd /tmp && go get -u github.com/vbatts/git-validation


....

# golang.org/x/sys/unix
Error: /home/runner/work/distribution/distribution/src/golang.org/x/sys/unix/syscall.go:83:16: undefined: unsafe.Slice
Error: /home/runner/work/distribution/distribution/src/golang.org/x/sys/unix/syscall_linux.go:1018:20: undefined: unsafe.Slice
Error: /home/runner/work/distribution/distribution/src/golang.org/x/sys/unix/syscall_linux.go:2297:9: undefined: unsafe.Slice
Error: /home/runner/work/distribution/distribution/src/golang.org/x/sys/unix/syscall_unix.go:118:7: undefined: unsafe.Slice
Error: /home/runner/work/distribution/distribution/src/golang.org/x/sys/unix/sysvshm_unix.go:33:7: undefined: unsafe.Slice
Error: Process completed with exit code 2.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(failure is not related, as described above)

Copy link
Member

@milosgajdos milosgajdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This attempts to rip out https://github.com/distribution/distribution/pull/3812/files#r1038982612 from #3812 and we are aware of what the issue is hence approving and merging so we can get #3812 merged in.

@milosgajdos milosgajdos merged commit 82d6c3d into distribution:release/2.8 Apr 17, 2023
1 of 2 checks passed
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Jul 29, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [registry](https://github.com/distribution/distribution) | patch | `2.8.1` -> `2.8.2` |

---

### Release Notes

<details>
<summary>distribution/distribution (registry)</summary>

### [`v2.8.2`](https://github.com/distribution/distribution/releases/tag/v2.8.2)

[Compare Source](distribution/distribution@v2.8.1...v2.8.2)

##### What's Changed

-   Revert registry/client: set `Accept: identity` header when getting layers by [@&#8203;ndeloof](https://github.com/ndeloof) in distribution/distribution#3783
-   Parse `http` forbidden as denied by [@&#8203;vvoland](https://github.com/vvoland) in distribution/distribution#3914
-   Fix [CVE-2022-28391](https://www.cve.org/CVERecord?id=CVE-2022-28391) by bumping alpine from 3.14 to 3.16 by [@&#8203;thaJeztah](https://github.com/thaJeztah) ([#&#8203;3650](distribution/distribution#3650))
-   Fix [CVE-2023-2253](https://www.cve.org/CVERecord?id=CVE-2023-2253) runaway allocation on /v2/\_catalog  by [@&#8203;josegomezr](https://github.com/josegomezr) [`521ea3d9`](distribution/distribution@521ea3d)
-   Fix panic in inmemory driver by [@&#8203;wy65701436](https://github.com/wy65701436) in distribution/distribution#3815
-   bump up golang version (alternative) by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#3903
-   Dockerfile: update xx to v1.2.1 by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#3907
-   update to go1.19.9 by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#3908
-   Add code to handle pagination of parts. Fixes max layer size of 10GB bug by [@&#8203;DavidSpek](https://github.com/DavidSpek) in distribution/distribution#3893
-   Dockerfile: fix filenames of artifacts by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#3911

**Full Changelog**: distribution/distribution@v2.8.1...v2.8.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yMy4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/20
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants