Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Disable autofix for EmptyConditionalBody #42

Merged
merged 1 commit into from Feb 1, 2024
Merged

FIX: Disable autofix for EmptyConditionalBody #42

merged 1 commit into from Feb 1, 2024

Conversation

CvX
Copy link
Contributor

@CvX CvX commented Feb 1, 2024

No description provided.

davidtaylorhq
davidtaylorhq approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@davidtaylorhq davidtaylorhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we report upstream? Would be good to link from the commit if so

@CvX
Copy link
Contributor Author

CvX commented Feb 1, 2024

Not reported yet. I wrote a failing spec for the one issue (autocorrect generating invalid syntax) and while trying to fix this bug I found out that there are more issues so decided to just disable it for now. 🥲 Will report shortly.

@CvX CvX merged commit 4264eab into main Feb 1, 2024
2 checks passed
@CvX CvX deleted the fixme2 branch February 1, 2024 23:02
@CvX
Copy link
Contributor Author

CvX commented Feb 1, 2024

  1. EmptyConditionalBody autocorrect generates invalid syntax rubocop/rubocop#12668
  2. EmptyConditionalBody autocorrect can result in breaking logic changes rubocop/rubocop#12669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaylorhq davidtaylorhq davidtaylorhq approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@CvX @davidtaylorhq