fix: add sanitizer to ldap account and password #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed: dexidp#3354 Signed-off-by: hsinhoyeh <yhh92u@gmail.com>
Signed-off-by: hsinhoyeh <yhh92u@gmail.com>
hsinhoyeh
force-pushed
the
fix---ldap-injection
branch
from
3a7b1a8
to
ccab708
Compare
|
hi @nabokihms knowing you were busy, but this requires your attention. |
nabokihms
approved these changes
Mar 11, 2024
|
Looks good from my point of view. The only thing left is to satisfy the linter. |
hsinhoyeh
force-pushed
the
fix---ldap-injection
branch
from
b13fb33
to
8fb472d
Compare
fixed, thanks @nabokihms |
nabokihms
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Let's go with this change without additional flags. It sounds like a sane security improvement./ Hope nobody uses wildcards in passwords.
We can add a feature flag if there are such cases.
|
@hsinhoyeh thank you for your contribution. |
3 tasks
nabokihms
added a commit
to deckhouse/3p-dex
that referenced
this pull request
Apr 9, 2024
With the change introduced in dexidp#3372 Dex declines passwords that contain special characters. Since password is not passed to any kind of filters, it is safe to pass a password as is. No LDAP query injections are possible. This commit is a revert of password escaping. Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
nabokihms
added a commit
that referenced
this pull request
Apr 9, 2024
With the change introduced in #3372 Dex declines passwords that contain special characters. Since password is not passed to any kind of filters, it is safe to pass a password as is. No LDAP query injections are possible. This commit is a revert of password escaping. Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
nabokihms
added a commit
to deckhouse/3p-dex
that referenced
this pull request
Apr 9, 2024
With the change introduced in dexidp#3372 Dex declines passwords that contain special characters. Since password is not passed to any kind of filters, it is safe to pass a password as is. No LDAP query injections are possible. This commit is a revert of password escaping. Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
this patch draws error when queys (i.e. account / password) against ldap contain wildcard.
What this PR does / why we need it
fixes #3354
Special notes for your reviewer
not sure whether it would impact the existing usecases or not, but I an open to accept additional switcher to on/off.