Also set the username in authproxy connector #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests Signed-off-by: Patrick Pacher <patrick.pacher@gmail.com>
ppacher
force-pushed
the
fix/authproxy/set-username
branch
from
b2c1ba9
to
3b00639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
authproxyconnector only sets thepreferred_usernamebut notusername. This causes issues with some OIDC clients that don't fallback topreferred_username.One example here is
ralllybut I also noticed that there's no username when using dex with WikiJS.What this PR does / why we need it
In addition to
preferred_username, the authproxy connector now also set's theUsernamefield on theconnector.Identity