Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct Loader object shadowing to correct SEGFAULT #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

correct Loader object shadowing to correct SEGFAULT #213

wants to merge 1 commit into from

Conversation

pbailey-hf
Copy link

This addresses issue #204. I traced the issue to

bomber/lib/loader.go

Line 151 in 79b5dc7

exists, err := l.Afs.Exists(ignoreFile)
where a SEGFAULT occurs due to l.Afs == null.

@pbailey-hf pbailey-hf marked this pull request as ready for review March 28, 2024 19:20
@pbailey-hf pbailey-hf mentioned this pull request Mar 28, 2024
Open
@pbailey-hf pbailey-hf changed the title scope Loader object to function to correct windows SEGFAULT scope Loader object to function to correct SEGFAULT Apr 3, 2024
@pbailey-hf
Copy link
Author

pbailey-hf commented Apr 3, 2024 •
edited

I have verified that this corrects segfault behavior on Linux as well. Tested on AL2023.

@pbailey-hf pbailey-hf changed the title scope Loader object to function to correct SEGFAULT correct Loader object shadowing to correct SEGFAULT Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pbailey-hf