Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to make build targets transitive #360

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Conversation

kzu
Copy link
Member

@kzu kzu commented Mar 22, 2023

This is no longer needed now that we update NuGetizer package reference to always be PrivateAssets=all, to account for users not doing it (misconfig issue).

This also fixes the issue with multi-targeting projects referencing nugetizer now since we had the wrong path for importing targets in that case.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This is no longer needed now that we update NuGetizer package reference to always be PrivateAssets=all, to account for users not doing it (misconfig issue).

This also fixes the issue with multi-targeting projects referencing nugetizer now since we had the wrong path for importing targets in that case.
@kzu kzu added the bug Something isn't working label Mar 22, 2023
@kzu kzu enabled auto-merge (rebase) March 22, 2023 16:55
@kzu kzu merged commit 250ecbb into main Mar 22, 2023
@kzu kzu deleted the dev/BuildNonTransitive branch March 22, 2023 17:08
@devlooped devlooped locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant