Improve event typing and update web3 for the web3-1.0.0 target
#152
Conversation
* Upgrade the `web3-1.0.0` target's `web3` version to the latest beta (54) * Adjust test setup and assertions to reflect `web3` changes
* Parse event inputs in order to improve the typing of contract events for the `web3-1.0.0` target * Update existing types to reflect updated `web3` (e.g. `EstimateGasOptions`)
| @@ -17,7 +17,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "tsc": "tsc --noEmit", | |||
| "mocha": "NODE_ENV=test mocha --require ts-node/register.js './**/*.spec.web3.ts'", | |||
| "mocha": "NODE_ENV=test mocha --require ts-node/register.js './**/*.spec.web3.ts' --timeout 5000", | |||
There was a problem hiding this comment.
Some of the tests took over 2s (Mocha's default) on my computer.
| @@ -10,7 +10,9 @@ export let web3: Web3; | |||
| export let accounts: string[]; | |||
|
|
|||
| export async function createNewBlockchain() { | |||
| const web3 = new Web3(ganache.provider()); | |||
| const web3 = new Web3(ganache.provider(), undefined, { | |||
| transactionConfirmationBlocks: 1, | |||
There was a problem hiding this comment.
I didn't look too deeply into this, but without this option, Web3 seemed to hang around for more confirmations.
There was a problem hiding this comment.
Hmm i saw similar behaviour with SOME web3 versions in the past.
|
|
||
| describe("ContractWithOverloads", () => { | ||
| it("should work", async () => { | ||
| const contract = (await deployContract("ContractWithOverloads")) as ContractWithOverloads; | ||
| const contract = await deployContract<ContractWithOverloads>("ContractWithOverloads"); |
There was a problem hiding this comment.
I don't know which style is preferred; this is just like the other test now.
Pull Request Test Coverage Report for Build 204
💛 - Coveralls |
| }); | ||
|
|
||
| it("should allow to pass signed values in multiple ways", async () => { | ||
| const contract = await deployContract<DumbContract>("DumbContract"); | ||
|
|
||
| expect(await contract.methods.returnSigned(2).call()).to.be.eq("2"); | ||
| expect(await contract.methods.returnSigned("2").call()).to.be.eq("2"); | ||
| expect((await contract.methods.returnSigned(2).call()).toString()).to.be.eq("2"); |
There was a problem hiding this comment.
according to new typings this should be BN, right? Could you add some kind of type assertion as well?
There was a problem hiding this comment.
Good idea, I've now done this in 44e6062 .
It looks like there's still some BigNumber/BN confusion to sort out in web3: web3/web3.js#2468
JamesLefrere
force-pushed
the
feature/improve-event-typing-and-update-web3
branch
from
70b30bd
to
44e6062
Compare
|
Merged! sorry that it took so long and thanks for contribution! |
Hey @krzkaczor , this is a great project! I had a go at improving the types for events, so that event listeners/event callbacks have properly typed params:
While I was at it, I updated the
web3version; the biggest change here is probably the BigNumber change in web3: web3/web3.js#2570Changes
web3-1.0.0target'sweb3version to the latest beta (54)web3changesweb3-1.0.0targetweb3(e.g.EstimateGasOptions)Let me know what you think. Cheers!