Update the ruleset regex to allow numbers #6635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6635 +/- ##
============================================
+ Coverage 85.13% 85.14% +0.01%
Complexity 4079 4079
============================================
Files 570 570
Lines 13363 13363
Branches 2402 2402
============================================
+ Hits 11376 11378 +2
+ Misses 791 790 -1
+ Partials 1196 1195 -1 ☔ View full report in Codecov by Sentry. |
schalkms
reviewed
Nov 19, 2023
detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/RuleSetSpec.kt
Outdated
Show resolved
Hide resolved
detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/RuleSetSpec.kt
Outdated
Show resolved
Hide resolved
detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/RuleSetSpec.kt
Outdated
Show resolved
Hide resolved
atulgpt
commented
Nov 19, 2023
detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/RuleSetSpec.kt
Outdated
Show resolved
Hide resolved
detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/RuleSetSpec.kt
Outdated
Show resolved
Hide resolved
…eSetSpec.kt Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com>
Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com>
schalkms
approved these changes
Nov 19, 2023
marschwar
approved these changes
Nov 20, 2023
BraisGabin
approved these changes
Nov 21, 2023
BraisGabin
added
the
pick request
cortinico
changed the title
cortinico
pushed a commit
that referenced
this pull request
Nov 25, 2023
* Update the regex to allow numbers * Update detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/RuleSetSpec.kt Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com> --------- Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com>
mgroth0
pushed a commit
to mgroth0/detekt
that referenced
this pull request
Feb 11, 2024
* Update the regex to allow numbers * Update detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/RuleSetSpec.kt Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com> --------- Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6619