Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnnecessaryBracesAroundTrailingLambda rule #6029

Merged
merged 3 commits into from May 9, 2023

Conversation

atulgpt
Copy link
Contributor

@atulgpt atulgpt commented Apr 22, 2023

Fixes #6008

@github-actions github-actions bot added the rules label Apr 22, 2023
@github-actions

This comment was marked as off-topic.

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #6029 (986ef7a) into main (07177a5) will increase coverage by 0.16%.
The diff coverage is 82.69%.

@@             Coverage Diff              @@
##               main    #6029      +/-   ##
============================================
+ Coverage     84.68%   84.85%   +0.16%     
- Complexity     3863     3982     +119     
============================================
  Files           550      566      +16     
  Lines         13115    13352     +237     
  Branches       2313     2344      +31     
============================================
+ Hits          11107    11330     +223     
- Misses          868      871       +3     
- Partials       1140     1151      +11     
Impacted Files Coverage Δ
...ambdaout/MoveLambdaOutsideParenthesesInspection.kt 74.28% <74.28%> (ø)
...rturbosch/detekt/rules/style/StyleGuideProvider.kt 100.00% <100.00%> (ø)
...lambdaout/UnnecessaryBracesAroundTrailingLambda.kt 100.00% <100.00%> (ø)

... and 40 files with indirect coverage changes

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@detekt-ci
Copy link
Collaborator

detekt-ci commented Apr 30, 2023

Messages
📖 Thanks for adding a new rule to detekt ❤️
We detekted that you added tests, to your rule, that's awesome!

We detekted that you updated the default-detekt-config.yml file, that's awesome!

Generated by 🚫 dangerJS against 986ef7a

@cortinico cortinico added this to the 1.23.0 milestone Apr 30, 2023
@cortinico cortinico added the notable changes Marker for notable changes in the changelog label Apr 30, 2023
Use name of the expression for issue reporting to avoid big yellow warning area
@cortinico cortinico merged commit 6d29614 into detekt:main May 9, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable changes Marker for notable changes in the changelog rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule for detecting unneccessary braces aroung the trailing lambda
4 participants