Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments with a list of regexes to ForbiddenComment #5981

Merged
merged 30 commits into from
May 21, 2023
Merged

Add comments with a list of regexes to ForbiddenComment #5981

merged 30 commits into from
May 21, 2023

Commits on Apr 10, 2023

  1. Add valuePatterns list of regexes

    @atulgpt
    atulgpt committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    6400988 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
    @atulgpt @TWiStErRob
    atulgpt and TWiStErRob committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5eba48b View commit details
    Browse the repository at this point in the history

  2. Deprecate values option

    @atulgpt
    atulgpt committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    6ef834c View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Check against complete text

    @atulgpt
    atulgpt committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    06350d1 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
    @atulgpt @TWiStErRob
    atulgpt and TWiStErRob committed May 6, 2023
    Configuration menu
    Copy the full SHA
    d9dc02f View commit details
    Browse the repository at this point in the history

  2. Update the valuePatterns config name to comments 

    Add tc when comment is present in between
    @atulgpt
    atulgpt committed May 6, 2023
    Configuration menu
    Copy the full SHA
    6e22238 View commit details
    Browse the repository at this point in the history

  3. Use static import of io.gitlab.arturbosch.detekt.test.assertThat

    @atulgpt
    atulgpt committed May 6, 2023
    Configuration menu
    Copy the full SHA
    e2a3af0 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Use valuesWithReason in comments config 

    Use custom `getContent` which returns comments with `/*`, `*/` and `*`
    @atulgpt
    atulgpt committed May 15, 2023
    Configuration menu
    Copy the full SHA
    7580f5c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Incorporate review comments and align comments for indented code

    @atulgpt
    atulgpt committed May 16, 2023
    Configuration menu
    Copy the full SHA
    8e11b39 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt… 

    …/rules/style/ForbiddenComment.kt


Remove `run` in `getErrorMessage`

Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
    @atulgpt @TWiStErRob
    atulgpt and TWiStErRob committed May 18, 2023
    Configuration menu
    Copy the full SHA
    42a80c7 View commit details
    Browse the repository at this point in the history

  2. Refactor code make trimIndentIgnoringFirstLine out 

    Trim start white space as to align with starting `*`
Add more TCs
    @atulgpt
    atulgpt committed May 18, 2023
    Configuration menu
    Copy the full SHA
    373bc23 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Shorten name: if it's trimmed, it cannot be also "full"

    @TWiStErRob
    TWiStErRob committed May 19, 2023
    Configuration menu
    Copy the full SHA
    a97dcab View commit details
    Browse the repository at this point in the history

  2. Test name fixes

    @TWiStErRob
    TWiStErRob committed May 19, 2023
    Configuration menu
    Copy the full SHA
    b747f77 View commit details
    Browse the repository at this point in the history

  3. Add tests for trailing and other mixed code-comment pairs

    @TWiStErRob
    TWiStErRob committed May 19, 2023
    Configuration menu
    Copy the full SHA
    007d3b4 View commit details
    Browse the repository at this point in the history

  4. Migrate detekt config to use new property. Fixes: 

    > Task :detekt-test:detektMain
Property 'style>ForbiddenComment>values' is deprecated. Use `comments` instead, make sure you escape your text for Regular Expressions..

History:
@requiresTypeResolution: detekt#3579 + 13a8389
@author: detekt#1776
    @TWiStErRob
    TWiStErRob committed May 19, 2023
    Configuration menu
    Copy the full SHA
    4687325 View commit details
    Browse the repository at this point in the history

  5. Format for visibility

    @TWiStErRob
    TWiStErRob committed May 19, 2023
    Configuration menu
    Copy the full SHA
    ffff4f7 View commit details
    Browse the repository at this point in the history

  6. Document behavior, add tests for documented behaviors and fix them.

    @TWiStErRob
    TWiStErRob committed May 19, 2023
    Configuration menu
    Copy the full SHA
    b4ca396 View commit details
    Browse the repository at this point in the history

  7. De-noise ForbiddenComment instance creations

    @TWiStErRob
    TWiStErRob committed May 19, 2023
    Configuration menu
    Copy the full SHA
    5673f92 View commit details
    Browse the repository at this point in the history

  8. Fix test snippets

    @TWiStErRob
    TWiStErRob committed May 19, 2023
    Configuration menu
    Copy the full SHA
    60d53f1 View commit details
    Browse the repository at this point in the history

  9. Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt… 

    …/rules/style/ForbiddenComment.kt

Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
    @atulgpt @TWiStErRob
    atulgpt and TWiStErRob committed May 19, 2023
    Configuration menu
    Copy the full SHA
    3c31fe0 View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
    @atulgpt @TWiStErRob
    atulgpt and TWiStErRob committed May 19, 2023
    Configuration menu
    Copy the full SHA
    ee18e1a View commit details
    Browse the repository at this point in the history

  11. Refactor report to common reportCodeSmell method

    @atulgpt
    atulgpt committed May 19, 2023
    Configuration menu
    Copy the full SHA
    b6f35e9 View commit details
    Browse the repository at this point in the history

  12. Update TC to reflect the updated message

    @atulgpt
    atulgpt committed May 19, 2023
    Configuration menu
    Copy the full SHA
    a5be5a4 View commit details
    Browse the repository at this point in the history

  13. Update the detekt.yml ForbiddenComment reason config to match the… 

    … default values
    @atulgpt
    atulgpt committed May 19, 2023
    Configuration menu
    Copy the full SHA
    1565fb6 View commit details
    Browse the repository at this point in the history

  14. Improve marker removal docs

    @TWiStErRob
    TWiStErRob committed May 19, 2023
    Configuration menu
    Copy the full SHA
    f4c59c1 View commit details
    Browse the repository at this point in the history

  15. Clarify why it matters.

    @TWiStErRob
    TWiStErRob committed May 19, 2023
    Configuration menu
    Copy the full SHA
    948cb73 View commit details
    Browse the repository at this point in the history

  16. Update the warning message to only use reason if available

    @atulgpt
    atulgpt committed May 19, 2023
    Configuration menu
    Copy the full SHA
    0a1763f View commit details
    Browse the repository at this point in the history

  17. Remove not necessary ZWSP

    @atulgpt
    atulgpt committed May 19, 2023
    Configuration menu
    Copy the full SHA
    b03bd56 View commit details
    Browse the repository at this point in the history

  18. Update message to remove in detekt

    @atulgpt
    atulgpt committed May 19, 2023
    Configuration menu
    Copy the full SHA
    fe491f6 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. Minor clarifications and formatting.

    @TWiStErRob
    TWiStErRob committed May 20, 2023
    Configuration menu
    Copy the full SHA
    6166297 View commit details
    Browse the repository at this point in the history