Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UnnecessaryAbstractClass only run with type resolution #5829

Merged
merged 1 commit into from Feb 26, 2023

Conversation

BraisGabin
Copy link
Member

Fix #4753

This rule has false positives without type resolution. More about this here: #4753

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #5829 (c0f2167) into main (dd49a0f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #5829   +/-   ##
=========================================
  Coverage     84.59%   84.59%           
  Complexity     3790     3790           
=========================================
  Files           546      546           
  Lines         12918    12918           
  Branches       2268     2268           
=========================================
  Hits          10928    10928           
  Misses          861      861           
  Partials       1129     1129           
Impacted Files Coverage Δ
...sch/detekt/rules/style/UnnecessaryAbstractClass.kt 77.35% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TWiStErRob TWiStErRob added this to the 1.23.0 milestone Feb 24, 2023
@cortinico cortinico added the notable changes Marker for notable changes in the changelog label Feb 26, 2023
@cortinico
Copy link
Member

One rule down from:

@BraisGabin BraisGabin merged commit 1a20458 into main Feb 26, 2023
@BraisGabin BraisGabin deleted the fix-4753 branch February 26, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable changes Marker for notable changes in the changelog rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnnecessaryAbstractClass false positive
3 participants