Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split UnusedPrivateMember #5722

Merged
merged 29 commits into from
Feb 5, 2023
Merged

Split UnusedPrivateMember #5722

merged 29 commits into from
Feb 5, 2023

Commits on Jan 23, 2023

  1. Run ktlint --format on files about to be touched

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    968683f View commit details
    Browse the repository at this point in the history

  2. Make UnusedPrivateMember focus on private functions

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    7cb6c0f View commit details
    Browse the repository at this point in the history

  3. Extract UnusedParameter

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    806a415 View commit details
    Browse the repository at this point in the history

  4. Extract UnusedParameter

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    429142c View commit details
    Browse the repository at this point in the history

  5. Extract UnusedPrivateProperty

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    09a7c6b View commit details
    Browse the repository at this point in the history

  6. Move first batch of property tests from inside UnusedPrivateMemberSpec

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    7c50787 View commit details
    Browse the repository at this point in the history

  7. Move second batch of property tests from inside UnusedPrivateMemberSpec

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    eb11585 View commit details
    Browse the repository at this point in the history

  8. Readjust expectations in test now that subject only detects unused pr… 

    …ivate properties
    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    a86e950 View commit details
    Browse the repository at this point in the history

  9. Move over next batch of property tests from UnusedPrivateMemberSpec

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    7ff9c21 View commit details
    Browse the repository at this point in the history

  10. Move one test from "unused class declarations which are allowed"

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    39491ae View commit details
    Browse the repository at this point in the history

  11. Move "nested class declarations" from UnusedPrivateMemberSpec

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    49df7cb View commit details
    Browse the repository at this point in the history

  12. Split "error messages"

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    939c679 View commit details
    Browse the repository at this point in the history

  13. Move "suppress unused property warning annotations"

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    f6ffe46 View commit details
    Browse the repository at this point in the history

  14. Move "main methods" inner test class

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    2406a24 View commit details
    Browse the repository at this point in the history

  15. Move "backtick identifiers" inner test class

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    8048a00 View commit details
    Browse the repository at this point in the history

  16. Move "backtick identifiers" inner test class for unused private param… 

    …eters
    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    4376627 View commit details
    Browse the repository at this point in the history

  17. Split "highlights declaration name"

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    93f090d View commit details
    Browse the repository at this point in the history

  18. Move "parameter with the same name as named argument"

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    99a350b View commit details
    Browse the repository at this point in the history

  19. Split "actual functions and classes"

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    636b3ad View commit details
    Browse the repository at this point in the history

  20. Move "properties in primary constructors"

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    18830f8 View commit details
    Browse the repository at this point in the history

  21. Fix typo

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    5227986 View commit details
    Browse the repository at this point in the history

  22. Fix disabled tests

    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    9241ae4 View commit details
    Browse the repository at this point in the history

  23. Add alias "UnusedPrivateMember" to UnusedParameter and UnusedPrivateP… 

    …roperty so it doesn't become a breaking change
    @drawers
    drawers committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    8c4c509 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Rename "UnusedPrivateParameterSpec" to "UnusedParameterSpec"

    @drawers
    drawers committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    b563ece View commit details
    Browse the repository at this point in the history

  2. Adjust KDoc to say "source file" instead of "class etc." for clarity

    @drawers
    drawers committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5a3a901 View commit details
    Browse the repository at this point in the history

  3. Adjust KDoc to explain how UnusedPrivateProperty can detect unused co… 

    …nstructor params
    @drawers
    drawers committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5897a31 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. inline method

    @chao2zhang
    chao2zhang committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    1e4bcb8 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2023

  1. Merge branch 'main' into fix-3418-split

    @schalkms
    schalkms committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    8f9a9e5 View commit details
    Browse the repository at this point in the history

  2. Remove duplicate main methods inner class after merge

    @drawers
    drawers committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    ddd19eb View commit details
    Browse the repository at this point in the history