Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowOperators in DataClassContainsFunctions #5658

Merged
merged 2 commits into from Jan 12, 2023

Conversation

atulgpt
Copy link
Contributor

@atulgpt atulgpt commented Jan 2, 2023

Fixes #5321

@BraisGabin
Copy link
Member

Oh! And thanks for your contributions :)

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #5658 (e67f3d0) into main (25b560f) will increase coverage by 85.93%.
The diff coverage is 50.00%.

❗ Current head e67f3d0 differs from pull request most recent head c6b8fad. Consider uploading reports for the commit c6b8fad to get more accurate results

@@             Coverage Diff             @@
##             main    #5658       +/-   ##
===========================================
+ Coverage        0   85.93%   +85.93%     
- Complexity      0     3659     +3659     
===========================================
  Files           0      517      +517     
  Lines           0    12220    +12220     
  Branches        0     2182     +2182     
===========================================
+ Hits            0    10501    +10501     
- Misses          0      628      +628     
- Partials        0     1091     +1091     
Impacted Files Coverage Δ
...h/detekt/rules/style/DataClassContainsFunctions.kt 88.88% <50.00%> (ø)
...arturbosch/detekt/core/baseline/DefaultBaseline.kt 75.00% <0.00%> (ø)
.../formatting/wrappers/DiscouragedCommentLocation.kt 100.00% <0.00%> (ø)
...urbosch/detekt/rules/exceptions/PrintStackTrace.kt 78.94% <0.00%> (ø)
.../detekt/formatting/wrappers/SpacingAroundParens.kt 100.00% <0.00%> (ø)
...wrappers/SpacingBetweenDeclarationsWithComments.kt 100.00% <0.00%> (ø)
...hub/detekt/metrics/processors/AbstractProcessor.kt 100.00% <0.00%> (ø)
...h/detekt/rules/style/MultilineLambdaItParameter.kt 93.10% <0.00%> (ø)
...gitlab/arturbosch/detekt/rules/style/UseOrEmpty.kt 75.47% <0.00%> (ø)
...osch/detekt/formatting/wrappers/MultiLineIfElse.kt 100.00% <0.00%> (ø)
... and 508 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@atulgpt
Copy link
Contributor Author

atulgpt commented Jan 2, 2023

Oh! And thanks for your contributions :)

Thanks :)

@atulgpt
Copy link
Contributor Author

atulgpt commented Jan 3, 2023

Hi @BraisGabin can you guide me why there is one check failing? Thanks

Decouple if checks
@BraisGabin BraisGabin merged commit 1fe9a98 into detekt:main Jan 12, 2023
@BraisGabin BraisGabin added this to the 1.23.0 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataClassContainsFunctions: operator overloading is flagged
2 participants