Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 is the new tracking tag #506

Merged
merged 1 commit into from Mar 21, 2024
Merged

v2 is the new tracking tag #506

merged 1 commit into from Mar 21, 2024

Conversation

jeffwidman
Copy link
Member

We're about to cut a new major version of this action, and we don't anticipate any further releases of the v1 line.

So I simply updated the automation to float the v2 tag.

Technically we could make it so it intelligently looks at the release number and updates the appropriate tag, but that'd be a bit more work and we don't need that complexity in this repo right now given our very infrequent cadence of bumping major versions.

As explained in a code comment:

    # We have a choice - defensiveness vs convenience:
    # 1. Be defensive by filtering if the release doesn't look like a normal
    #    version, or if it's a patch release to an older version... the logic
    #    gets tricky quickly. Easiest way to be 100% sure is stop running this
    #    on `release` and instead require a human to manually run this workflow
    #    after they tag a release.
    # 2. Minimize the upfront hassle by assuming every release is a normal
    #    version release and the latest one. Today both are resoundingly true
    #    as this repo isn't that active/busy, so we don't worry about
    #    multiple release branches, pre-releases, etc.
    #
    # For now I've gone with option 2, as it is much more convenient and if we
    # typo something during a release it's easy to fix by immediately tagging a
    # correct release. And if we don't notice the typo, well, in that case
    # requiring a human to manually run the workflow wouldn't have protected us
    # either, we'd have had to filter by only things that look like versions.
    # Anyway, for now this is good enough, and if it gets to be a problem down
    # the road we increase the robustness of this.

We're about to cut a new major version of this action,
and we don't anticipate any further releases of the `v1`
line.

So I simply updated the automation to float the `v2` tag.

Technically we could make it so it intelligently looks at
the release number and updates the appropriate tag, but
that'd be a bit more work and we don't need that complexity
in this repo right now given our very infrequent cadence of
bumping major versions.

As explained in a [code comment](https://github.com/dependabot/fetch-metadata/blob/f2f0ad1522845af9cf040e91326888ed5d56e3f8/.github/workflows/release-move-tracking-tag.yml#L11-L28):
```
    # We have a choice - defensiveness vs convenience:
    # 1. Be defensive by filtering if the release doesn't look like a normal
    #    version, or if it's a patch release to an older version... the logic
    #    gets tricky quickly. Easiest way to be 100% sure is stop running this
    #    on `release` and instead require a human to manually run this workflow
    #    after they tag a release.
    # 2. Minimize the upfront hassle by assuming every release is a normal
    #    version release and the latest one. Today both are resoundingly true
    #    as this repo isn't that active/busy, so we don't worry about
    #    multiple release branches, pre-releases, etc.
    #
    # For now I've gone with option 2, as it is much more convenient and if we
    # typo something during a release it's easy to fix by immediately tagging a
    # correct release. And if we don't notice the typo, well, in that case
    # requiring a human to manually run the workflow wouldn't have protected us
    # either, we'd have had to filter by only things that look like versions.
    # Anyway, for now this is good enough, and if it gets to be a problem down
    # the road we increase the robustness of this.

```
@jeffwidman jeffwidman requested a review from a team as a code owner March 21, 2024 18:07
@jeffwidman jeffwidman merged commit dc2c459 into main Mar 21, 2024
6 checks passed
@jeffwidman jeffwidman deleted the prep-for-v2-release branch March 21, 2024 21:28
zeebe-bors bot added a commit to zeebe-io/zeebe-cluster-testbench that referenced this pull request Apr 8, 2024
1021: chore(deps): update dependabot/fetch-metadata action to v2 r=korthout a=renovate[bot]

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [dependabot/fetch-metadata](https://togithub.com/dependabot/fetch-metadata) | action | major | `v1.7.0` -> `v2.0.0` |

---

### Release Notes

<details>
<summary>dependabot/fetch-metadata (dependabot/fetch-metadata)</summary>

### [`v2.0.0`](https://togithub.com/dependabot/fetch-metadata/releases/tag/v2.0.0): - Switch to `node20`

[Compare Source](https://togithub.com/dependabot/fetch-metadata/compare/v1.7.0...v2.0.0)

#### What's Changed

-   Upgrade from node16 to node20 by [`@&#8203;Nishnha](https://togithub.com/Nishnha)` in [dependabot/fetch-metadata#443 👈 this is a potentially breaking change for some workflows
-   `v2` is the new tracking tag by [`@&#8203;jeffwidman](https://togithub.com/jeffwidman)` in [dependabot/fetch-metadata#506
-   v2.0.0 by [`@&#8203;fetch-metadata-action-automation](https://togithub.com/fetch-metadata-action-automation)` in [dependabot/fetch-metadata#508

**Full Changelog**: dependabot/fetch-metadata@v1.7.0...v2.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/zeebe-io/zeebe-cluster-testbench).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->


Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants