Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from node16 to node20 #443

Merged
merged 4 commits into from Mar 21, 2024
Merged

Upgrade from node16 to node20 #443

merged 4 commits into from Mar 21, 2024

Conversation

Nishnha
Copy link
Member

@Nishnha Nishnha commented Sep 21, 2023

Node16 is now EOL. The next LTS release is node18 which has support until 2025, but node20 has support until 2026.

https://nodejs.dev/en/about/releases/

@Nishnha
Copy link
Member Author

Nishnha commented Sep 21, 2023

CI is currently failing, but the tests all passed. One of our tests generates an error and it seems like the Actions runner is picking up on that and reporting the step as failed?

dependabot-pull-request-action@1.6.0 test
jest

PASS src/main.test.ts
Error: github-token is not set! Please add 'github-token: "${{ secrets.GITHUB_TOKEN }}"' to your workflow file.

PASS src/dependabot/update_metadata.test.ts
PASS src/dependabot/verified_commits.test.ts
PASS src/dependabot/output.test.ts

Test Suites: 4 passed, 4 total
Tests: 40 passed, 40 total
Snapshots: 0 total
Time: 4.206 s
Ran all test suites.

@jeffwidman
Copy link
Member

Is the underlying actions issue mentioned here related to the CI failures?

@Nishnha
Copy link
Member Author

Nishnha commented Oct 13, 2023

Is the underlying actions issue mentioned here related to the CI failures?

The original issue was but I think node 20 has shipped on Actions runners. Now I see a new error around a missing GitHub token that I can take care of in a bit.

@ParanoidUser
Copy link

As we near the deadline in Spring 2024, this action has begun generating deprecation warnings. Are there any obstacles in the migration process? I anticipate this becoming a prominent topic soon, as more individuals express frustration with these warnings.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: dependabot/fetch-metadata@c9c4182bf1b97f5224aee3906fd373f6b61b4526. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@Nishnha
Copy link
Member Author

Nishnha commented Jan 31, 2024

Are there any obstacles in the migration process?

Nope just got busy. We're going to release this as a major version update since it breaks compatibility with older GitHub Enterprise Server versions that don't ship with Node20. I'll create a minor release for whatever changes are on main first, though.

@hanseartic
Copy link
Contributor

Would really appreciate a release /w node20 support soon. Most of the actions are already migrated....

package.json Outdated Show resolved Hide resolved
@jeffwidman jeffwidman mentioned this pull request Mar 21, 2024
@jeffwidman
Copy link
Member

@Nishnha I'm unclear what's the next step here?

Do we need a minor release to catchup to HEAD and then merge this and cut a major release?

Should we land any of the other outstanding PR's first? I can take a look and make judgement calls but assume you've already looked at this?

Co-authored-by: Paul <schuette.paul@gmail.com>
@jeffwidman jeffwidman merged commit f2f0ad1 into main Mar 21, 2024
6 checks passed
@jeffwidman jeffwidman deleted the nishnha/use-node-20 branch March 21, 2024 17:58
zeebe-bors bot added a commit to zeebe-io/zeebe-cluster-testbench that referenced this pull request Apr 8, 2024
1021: chore(deps): update dependabot/fetch-metadata action to v2 r=korthout a=renovate[bot]

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [dependabot/fetch-metadata](https://togithub.com/dependabot/fetch-metadata) | action | major | `v1.7.0` -> `v2.0.0` |

---

### Release Notes

<details>
<summary>dependabot/fetch-metadata (dependabot/fetch-metadata)</summary>

### [`v2.0.0`](https://togithub.com/dependabot/fetch-metadata/releases/tag/v2.0.0): - Switch to `node20`

[Compare Source](https://togithub.com/dependabot/fetch-metadata/compare/v1.7.0...v2.0.0)

#### What's Changed

-   Upgrade from node16 to node20 by [`@&#8203;Nishnha](https://togithub.com/Nishnha)` in [dependabot/fetch-metadata#443 👈 this is a potentially breaking change for some workflows
-   `v2` is the new tracking tag by [`@&#8203;jeffwidman](https://togithub.com/jeffwidman)` in [dependabot/fetch-metadata#506
-   v2.0.0 by [`@&#8203;fetch-metadata-action-automation](https://togithub.com/fetch-metadata-action-automation)` in [dependabot/fetch-metadata#508

**Full Changelog**: dependabot/fetch-metadata@v1.7.0...v2.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/zeebe-io/zeebe-cluster-testbench).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->


Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants