New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable v8 sandbox #1485

Open

ry wants to merge 1 commit into main from sandbox

Member

ry commented May 17, 2024

No description provided.


          enable v8 sandbox

4e8a1b5

ry requested review from mmastrac and bartlomieju

May 17, 2024 17:53

Contributor

mmastrac commented May 17, 2024

Hmm. Is there a new step we need to add to init?

#
# Fatal error in , line 0
# Check failed: i::GetProcessWideSandbox()->is_initialized().
#
#
#

Member

bartlomieju commented May 20, 2024

@mmastrac appears this is done in V8::initialize():

https://github.com/denoland/v8/blob/35447497cb1589588d68a3c6a90a0b676742ba2a/src/init/v8.cc#L266-L272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment