Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/fetch): support fallible request-builder hooks #18116

Merged
merged 1 commit into from
Mar 13, 2023

Commits on Mar 10, 2023

  1. feat(ext/fetch): support fallible request-builder hooks

    This tweaks the signature of `request_builder_hook` in order to
    support fallible hooks.
    
    The rationale for this is mostly on two sides:
     * it allows a hook to inspect and possibly drop an outgoing request
       (e.g. for policying purposes), bubbling up a detailed error
       message to the user.
     * it wires into newer `reqwest` API which allows to split and
       then reassemble a `RequestBuilder`, although only in a fallible
       way.
    lucab committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    724f9c1 View commit details
    Browse the repository at this point in the history