Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gr100 uses items not in marketplaces #4282

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

barryyosi-panw
Copy link

Related Issues

fixes: CIAC-10572

Description

Refactoring 'marketplaces' field validation (Content item uses items not in marketplace - GR100)

@barryyosi-panw barryyosi-panw changed the title Gr100 uses items not int marketplaces Gr100 uses items not in marketplaces May 19, 2024
Copy link

Changelog(s) in markdown:

  • Refactored validation GR100, that checks whether a content item attempts to use other content items which are not supported in all of the marketplaces of the content item. #4282

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
see my comments.

validation_results = []

for content_item in self.graph.find_uses_paths_with_invalid_marketplaces(
[item.pack_id for item in content_items]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to discuss this
@moishce @YuvHayun @ShahafBenYakir FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants