-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gr100 uses items not in marketplaces #4282
Open
barryyosi-panw
wants to merge
17
commits into
master
Choose a base branch
from
gr100-uses-items-not-int-marketplaces
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barryyosi-panw
requested review from
dantavori and
RosenbergYehuda
as code owners
May 19, 2024 12:11
barryyosi-panw
changed the title
Gr100 uses items not int marketplaces
Gr100 uses items not in marketplaces
May 19, 2024
Changelog(s) in markdown:
|
YuvHayun
requested changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
see my comments.
demisto_sdk/commands/validate/validators/GR_validators/GR100_uses_items_not_in_market_place.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/GR_validators/GR100_uses_items_not_in_market_place.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/GR_validators/GR100_uses_items_not_in_market_place.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/GR_validators/GR100_uses_items_not_in_market_place.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/GR_validators/GR100_uses_items_not_in_market_place.py
Outdated
Show resolved
Hide resolved
…ses_items_not_in_market_place.py Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
dantavori
reviewed
May 21, 2024
validation_results = [] | ||
|
||
for content_item in self.graph.find_uses_paths_with_invalid_marketplaces( | ||
[item.pack_id for item in content_items] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to discuss this
@moishce @YuvHayun @ShahafBenYakir FYI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: CIAC-10572
Description
Refactoring 'marketplaces' field validation (Content item uses items not in marketplace - GR100)