Refactor validation IF119 #4277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog(s) in markdown:
|
DeanArbel
approved these changes
May 16, 2024
...s/IF119_select_values_cannot_contain_multiple_or_only_empty_values_in_single_select_types.py
Outdated
Show resolved
Hide resolved
YuvHayun
requested changes
May 19, 2024
| @@ -0,0 +1,4 @@ | |||
| changes: | |||
| - description: Refactored validation IF119, Check whether a selectValue key in an incidentField of type singleSelect do not contain multiple or only empty options. | |||
There was a problem hiding this comment.
Suggested change
| - description: Refactored validation IF119, Check whether a selectValue key in an incidentField of type singleSelect do not contain multiple or only empty options. | |
| - description: Added support for validation IF119 - "check whether a selectValue key in an incidentField of type singleSelect do not contain multiple or only empty options." for new validate flow. |
| def select_values_do_not_contain_multiple_or_only_empty_values_in_single_select_types( | ||
| content_item: ContentTypes, | ||
| ) -> bool: | ||
| if content_item.data.get("type") == IncidentFieldType.SINGLE_SELECT: |
There was a problem hiding this comment.
Let's add type as an attr of the IncidentField class.
| content_item: ContentTypes, | ||
| ) -> bool: | ||
| if content_item.data.get("type") == IncidentFieldType.SINGLE_SELECT: | ||
| select_values = content_item.data.get("selectValues") or [] |
| error_code = "IF119" | ||
| description = "We do not allow for incidentFields with singleSelect types to have in the selectValues more than one or only emtpy option" | ||
| rationale = "Due to UI issues, we cannot allow more than one or only empty values for selectValues field" | ||
| error_message = "singleSelect types cannot contain more than one or only empty values in the selectValues field." |
There was a problem hiding this comment.
Let's make sure only the relevant issue appears, maybe consider returning the relevant error msg rather than True/False from select_values_do_not_contain_multiple_or_only_empty_values_in_single_select_types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes:
Description
Refactored validation IF119, Check whether a selectValue key in an incidentField of type singleSelect do not contain multiple or only empty options.