RN103 + RN104 to the new format validation #4275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuvHayun
requested changes
May 26, 2024
| @@ -60,6 +61,7 @@ select = [ | |||
| "DO100", "DO101", "DO102", "DO103", "DO104", | |||
| "SC100", "SC105", "SC106", "SC109", | |||
| "RM104", "RM105", "RM113", "RM114", | |||
| "RN103", | |||
There was a problem hiding this comment.
I don't think RN validations are necessary when not running in -g
demisto_sdk/commands/validate/validators/RN_validators/RN103_is_release_notes_filled_out.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/RN_validators/RN103_is_release_notes_filled_out.py
Outdated
Show resolved
Hide resolved
| error_code = "RN103" | ||
| description = "Validate that the pack contains a full release note file. " | ||
| rationale = "Meaningful, complete documentations make it easier for users to use the content." | ||
| error_message = "Please finish filling out the release notes. For common troubleshooting steps, please "\ |
There was a problem hiding this comment.
Let's also make sure to tip about removing the placeholders.
Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
# Conflicts: # demisto_sdk/commands/validate/sdk_validation_config.toml
|
Changelog(s) in markdown:
|
YuvHayun
approved these changes
Jun 3, 2024
demisto_sdk/commands/validate/validators/RN_validators/RN103_is_release_notes_filled_out.py
Show resolved
Hide resolved
|
Changelog(s) in markdown:
|
YuvHayun
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
relates: https://jira-dc.paloaltonetworks.com/browse/CIAC-7806
Description
Joined Rn103 and RN104 to the new validation format