add pb validations #4273
Merged
add pb validations #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog(s) in markdown:
|
merit-maita
requested review from
dantavori and
RosenbergYehuda
and removed request for
dantavori and
RosenbergYehuda
merit-maita
requested review from
YuvHayun
and removed request for
dantavori and
RosenbergYehuda
# Conflicts: # demisto_sdk/commands/validate/sdk_validation_config.toml
thefrieddan1
requested changes
May 19, 2024
| # Rename the keys in dictionary to upper case | ||
| next_tasks_upper = {k.upper(): v for k, v in next_tasks.items()} | ||
|
|
||
| mapper_dict = { |
There was a problem hiding this comment.
Seems like we can define this once outside the nested for loops. as a CONST
...dk/commands/validate/validators/PB_validators/PB101_is_playbook_has_unreachable_condition.py
Show resolved
Hide resolved
...dk/commands/validate/validators/PB_validators/PB101_is_playbook_has_unreachable_condition.py
Show resolved
Hide resolved
...s/validate/validators/PB_validators/PB123_is_conditional_task_has_unhandled_reply_options.py
Show resolved
Hide resolved
| # Rename the keys in dictionary to upper case | ||
| next_tasks_upper = {k.upper(): v for k, v in next_tasks.items()} | ||
|
|
||
| mapper_dict = { |
...s/validate/validators/PB_validators/PB123_is_conditional_task_has_unhandled_reply_options.py
Show resolved
Hide resolved
thefrieddan1
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-10535
Description