-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate BA109 #4206
base: master
Are you sure you want to change the base?
Validate BA109 #4206
Conversation
* added error msg for BA124 * fix cl100 description * pre commit fixes
…validate--ba109
…validate--ba109
…validate--ba109
…validate--ba109
…validate--ba109
…validate--ba109
…validate--ba109
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
See my comments.
if git_status != GitStatuses.RENAMED: | ||
statuses_dict[path] = git_status | ||
else: | ||
statuses_dict[path] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an addition you wrote because of an error I received
Related Issues
fixes:https://jira-dc.paloaltonetworks.com/browse/CIAC-9836
Description