Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate BA109 #4206

Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

Validate BA109 #4206

wants to merge 53 commits into from

Conversation

YairGlik
Copy link
Contributor

@YairGlik YairGlik commented Apr 4, 2024

@YairGlik YairGlik requested a review from jbabazadeh April 7, 2024 11:22
@YairGlik YairGlik requested review from YuvHayun and removed request for YuvHayun May 12, 2024 13:50
@YairGlik YairGlik requested a review from YuvHayun May 22, 2024 08:22
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
See my comments.

Comment on lines +529 to +532
if git_status != GitStatuses.RENAMED:
statuses_dict[path] = git_status
else:
statuses_dict[path] = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an addition you wrote because of an error I received

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants