Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve black performance #3613

Merged
merged 1 commit into from Sep 10, 2023
Merged

improve black performance #3613

merged 1 commit into from Sep 10, 2023

Conversation

dorschw
Copy link
Contributor

@dorschw dorschw commented Sep 10, 2023

Use pyc black hook, ~2x faster

psf/black#3828

GuyAfik
GuyAfik approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build cfdc2d13-d230-4634-968c-750236d0fb67

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 81.168%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/common/content/objects/pack_objects/pack_metadata/pack_metadata.py 1 95.67%
Totals Coverage Status
Change from base Build dede1326-2d45-485f-ba20-3b64febbac6a: -0.003%
Covered Lines: 31973
Relevant Lines: 39391
💛 - Coveralls

@dorschw dorschw merged commit f27ccc5 into master Sep 10, 2023
19 checks passed
@dorschw dorschw deleted the ds-black-faster branch September 10, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuyAfik GuyAfik GuyAfik approved these changes

@ilaner ilaner Awaiting requested review from ilaner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dorschw @coveralls @GuyAfik