fix: Delete messages from SMTP queue only on user demand (#4579) #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
commented
Aug 10, 2023
iequidoo
force-pushed
the
iequidoo/delete_msgs_from_smtp
branch
from
addb522
to
cffca24
Compare
|
@iequidoo It seems that you have not nominated/requested a reviewer, yet. |
that's usually not neccessary -- just a lot of people currently preparing for going to CCC camp next week (near berlin) and traveling/packing etc. |
iequidoo
force-pushed
the
iequidoo/delete_msgs_from_smtp
branch
from
cffca24
to
80e6661
Compare
3 tasks
link2xt
approved these changes
Aug 15, 2023
iequidoo
force-pushed
the
iequidoo/delete_msgs_from_smtp
branch
2 times, most recently
from
c69b161
to
cc424c9
Compare
|
|
I.e. from delete_msgs(). Otherwise messages must not be deleted from there, e.g. if a message is ephemeral, but a network outage lasts longer than the ephemeral message timer, the message still must be sent upon a successful reconnection.
iequidoo
force-pushed
the
iequidoo/delete_msgs_from_smtp
branch
from
cc424c9
to
36dfc7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. from delete_msgs(). Otherwise messages must not be deleted from there, e.g. if a message is ephemeral, but a network outage lasts longer than the ephemeral message timer, the message still must be sent upon a successful reconnection.