chore: datafusion 34, arrow & parquet 49 #1983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcake
requested review from
wjones127,
fvaleye,
roeap,
ion-elgreco and
rtyler
as code owners
github-actions
bot
added
binding/python
emcake
commented
Dec 19, 2023
| arrow-select = { version = "49.0.0" } | ||
| parquet = { version = "49.0.0" } | ||
|
|
||
| object_store = "0.8" |
There was a problem hiding this comment.
I moved object_store to a workspace dependency as it's referenced in two separate crates - easier to keep the dependency in sync this way.
|
@emcake - thanks for taking care of this! Seems there is one more clippy error to address :). |
|
I think this is now complete and up to date - there still appears to be some tests failing but I'm struggling to work out if these are flaky or real. |
|
@emcake the restore by datetime and a read test are super flaky.. |
|
@emcake maybe object store 0.8 is causing the read failures, can you revert to object store 0.7? |
|
Object store is coupled to datafusion. Had a first glance, and it seems like fixable problem, but may require some work. |
|
Looks like @roeap beat me to it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades DataFusion and Arrow to v34 and v49 respectively. As a casualty we also need to upgrade object_store to v0.8.
Related Issue(s)
Arrow 49 contains a fix to allow for truncated statistics on binary columns (apache/arrow-rs#5037) that I'd like to employ to fix #1805 .