-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow for more customizations for k3s installs #2495
Open
dgershman
wants to merge
4
commits into
defenseunicorns:main
Choose a base branch
from
radiusmethod:feature/customizable-k3s
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: allow for more customizations for k3s installs #2495
dgershman
wants to merge
4
commits into
defenseunicorns:main
from
radiusmethod:feature/customizable-k3s
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
AustinAbro321
changed the title
Allow for more customizations for k3s installs
feat: Allow for more customizations for k3s installs
May 13, 2024
AustinAbro321
changed the title
feat: Allow for more customizations for k3s installs
feat: allow for more customizations for k3s installs
May 13, 2024
dgershman
force-pushed
the
feature/customizable-k3s
branch
from
May 21, 2024 19:27
778ca6b
to
4258b0d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2495 +/- ##
=======================================
Coverage ? 26.62%
=======================================
Files ? 89
Lines ? 6715
Branches ? 0
=======================================
Hits ? 1788
Misses ? 4720
Partials ? 207 ☔ View full report in Codecov by Sentry. |
Hey @dgershman, I left some comments on #2243. It would be great to finalize and merge the ADR before starting the implementation. Thanks! |
lucasrod16
added
the
needs-adr
PR Label - Architectural Decision Records required to merge
label
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This would allow for more flexibility in creating a k3s installation; for example setting up a 2nd
agent
node.Related Issue
Relates to #2243
Checklist before merging