Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for more customizations for k3s installs #2495

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dgershman
Copy link
Collaborator

@dgershman dgershman commented May 10, 2024

Description

This would allow for more flexibility in creating a k3s installation; for example setting up a 2nd agent node.

Related Issue

Relates to #2243

Checklist before merging

Copy link

netlify bot commented May 10, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 8aeaebf
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/665e102621c6740008809d4b

@dgershman dgershman marked this pull request as ready for review May 11, 2024 03:19
@dgershman dgershman requested a review from a team as a code owner May 11, 2024 03:19
@AustinAbro321 AustinAbro321 changed the title Allow for more customizations for k3s installs feat: Allow for more customizations for k3s installs May 13, 2024
@AustinAbro321 AustinAbro321 changed the title feat: Allow for more customizations for k3s installs feat: allow for more customizations for k3s installs May 13, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@0527bea). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2495   +/-   ##
=======================================
  Coverage        ?   26.62%           
=======================================
  Files           ?       89           
  Lines           ?     6715           
  Branches        ?        0           
=======================================
  Hits            ?     1788           
  Misses          ?     4720           
  Partials        ?      207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucasrod16
Copy link
Member

Hey @dgershman,

I left some comments on #2243. It would be great to finalize and merge the ADR before starting the implementation.

Thanks!

@lucasrod16 lucasrod16 added the needs-adr PR Label - Architectural Decision Records required to merge label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-adr PR Label - Architectural Decision Records required to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants